Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opam and META files, add '-dir' to hol.sh, other updates #116

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

aqjune-aws
Copy link
Contributor

This patch

  • adds opam and META files.
  • add '-dir' to hol.sh: 'hol.sh -dir' prints its HOLLIGHT_DIR variable. This is convenient when one wants to know where hol light is installed :)
  • increases version at hol.ml to "3.0.0+" ('+' is to describe that there are updates after the official release)
  • updates README to explain how to use OPAM to install HOL Light

The contents of 'opam' file is equivalent to the already published version to the OPAM repository https://github.com/ocaml/opam-repository/blob/master/packages/hol_light/hol_light.3.0.0/opam modulo:

  • A reference to the released tar.gz
  • extra-source "META" because the META file will now be included in hol-light with this patch
  • Version number and some extra stuffs (they seem to extract those from the directory path)

META was necessary to help ocamlfind locate package 'hol_light'. When HOL Light is installed during OPAM installation, I uploaded this file at gist.github.com and download it; but I think it is a wiser idea to explicitly put it in this repo. :)

This patch
- adds opam and META files.
- add '-dir' to hol.sh: 'hol.sh -dir' prints its HOLLIGHT_DIR variable. This is convenient when one wants to know where hol light is installed :)
- increases version at hol.ml to "3.0.0+" ('+' is to describe that there are updates after the official release)
- updates README to explain how to use OPAM to install HOL Light

The contents of 'opam' file is equivalent to the already published version to the OPAM repository
https://github.com/ocaml/opam-repository/blob/master/packages/hol_light/hol_light.3.0.0/opam
modulo:
- A reference to the released tar.gz
- `extra-source "META"` because the META file will now be included in hol-light with this patch
- Version number and some extra stuffs (they seem to extract those from the directory path)

META was necessary to help ocamlfind locate package 'hol_light'.
When HOL Light is installed during OPAM installation, I uploaded this file at gist.github.com and
download it; but I think it is a wiser idea to explicitly put it in this repo. :)
Copy link
Owner

@jrh13 jrh13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, it's very nice to have opam support, and the other changes all make good sense. I've tried things out in my setup and everything works well, so I will merge this :-)

@jrh13 jrh13 merged commit b5e71c0 into jrh13:master Oct 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants